Support non streamed responses #3
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
🎁 Share your feedback on Copilot Code Reviews and get GitHub Shop credit!
- Complete this short 3 minute survey and tell us how we can improve Copilot Code Reviews for you and your team.
- Leave feedback on Copilot's comments using the 👍 and 👎 buttons on each review comment, and you could be one of 3 Hubbers to win a $50 GitHub Shop credit.
itsbagpack
approved these changes
Oct 7, 2024
Contributor
itsbagpack
left a comment
itsbagpack
left a comment
There was a problem hiding this comment.
I think the logic and structure makes sense! Left a couple of questions more around my lack of knowledge around this neck of the woods 😆
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Models like o1 require non-streamed responses. To make that work, I've introduced a common interface that lets us treat these like normal streamed responses (with one large chunk). I've also had to tweak the consuming code to accept data either from
.Deltaor.Message, since non-streamed responses will use.Message.While I'm here, I've added some more explicit instructions about developing/releasing this locally.