Scope ensures to only run if default_timezone actually altered
#22
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ensure at the method level runs on every method call, even early returns like the return self if sql.blank? check. This means that timezone was being set to nil sometimes if force_timezone was used and the sql was blank (early return). This fixes that bug.
See e442e84 for longer description of fix.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a particularly subtle and hard to catch bug.
ensurewhen used at the method definition level runs on every method call regardless of on early return. This means that when using:force_timezoneand callingresultsmore than once, the default_timezone was getting set to nil, because the second invocation would early return, not set thezonevariable and thus set default_timezone to nil in the ensure block.