Skip to content

Conversation

tonytrg
Copy link
Contributor

@tonytrg tonytrg commented Oct 13, 2025

We had multiple complaints that the docs were lacking ghes ghec documentation. This refactor highlights their configuration and fixes a error in the example url.

@tonytrg tonytrg requested a review from a team as a code owner October 13, 2025 08:36
@Copilot Copilot AI review requested due to automatic review settings October 13, 2025 08:36
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR restructures the README by moving the GitHub Enterprise Server and Enterprise Cloud configuration section from the bottom of the document to a more prominent position near the top, improving visibility for enterprise users.

  • Moved GHES/GHEC configuration section to appear earlier in the document
  • Updated the hostname example for GitHub Enterprise Cloud with data residency to use the correct API endpoint format
  • Maintained the same configuration examples and explanations

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

README.md Outdated
the hostname for GitHub Enterprise Server or GitHub Enterprise Cloud with data residency.

- For GitHub Enterprise Server, prefix the hostname with the `https://` URI scheme, as it otherwise defaults to `http://`, which GitHub Enterprise Server does not support.
- For GitHub Enterprise Cloud with data residency, use `https://copilot-api.YOURSUBDOMAIN.ghe.com` as the hostname.
Copy link

Copilot AI Oct 13, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The hostname format for GitHub Enterprise Cloud with data residency appears to have been updated to include 'copilot-api.' prefix, but this change should be verified against the official documentation to ensure accuracy.

Copilot uses AI. Check for mistakes.

@tonytrg tonytrg force-pushed the tonytrg/update-docs branch from fa12d2f to a81cb61 Compare October 13, 2025 08:37
Copy link
Member

@omgitsads omgitsads left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, just some thoughts about location


</details>

### GitHub Enterprise Server and Enterprise Cloud with data residency (ghe.com)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should this be moved under VSCode? The config is specifically for VSCode. Also if we're going to use ${input:github_token} perhaps that also needs to be provided in the config, though it's somewhat redundant doing it everywhere.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i want to clearly seperate it - so its clear these settings are client agnostic.
I will do a later review of the whole readme structure, as we keep getting complaints about settings/questions which are already in the readme docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants