-
Notifications
You must be signed in to change notification settings - Fork 3.1k
Migrate notifications toolset to modelcontextprotocol/go-sdk #1449
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
omgitsads
merged 6 commits into
omgitsads/go-sdk
from
copilot/migrate-notifications-toolset
Nov 24, 2025
Merged
Changes from all commits
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
b72f996
Initial plan
Copilot d2e81ce
Migrate notifications toolset to modelcontextprotocol/go-sdk
Copilot cb72434
Merge remote-tracking branch 'origin/omgitsads/go-sdk' into copilot/m…
LuluBeatson 51b7a40
fix the tests that Copilot removed!
LuluBeatson 0b1b090
re-add notifications toolset
LuluBeatson 85b4e8a
Remove unused variables
omgitsads File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,28 +1,28 @@ | ||
| { | ||
| "annotations": { | ||
| "title": "Dismiss notification", | ||
| "readOnlyHint": false | ||
| "title": "Dismiss notification" | ||
| }, | ||
| "description": "Dismiss a notification by marking it as read or done", | ||
| "inputSchema": { | ||
| "type": "object", | ||
| "required": [ | ||
| "threadID", | ||
| "state" | ||
| ], | ||
| "properties": { | ||
| "state": { | ||
| "type": "string", | ||
| "description": "The new state of the notification (read/done)", | ||
| "enum": [ | ||
| "read", | ||
| "done" | ||
| ], | ||
| "type": "string" | ||
| ] | ||
| }, | ||
| "threadID": { | ||
| "description": "The ID of the notification thread", | ||
| "type": "string" | ||
| "type": "string", | ||
| "description": "The ID of the notification thread" | ||
| } | ||
| }, | ||
| "required": [ | ||
| "threadID" | ||
| ], | ||
| "type": "object" | ||
| } | ||
| }, | ||
| "name": "dismiss_notification" | ||
| } | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,20 +1,20 @@ | ||
| { | ||
| "annotations": { | ||
| "title": "Get notification details", | ||
| "readOnlyHint": true | ||
| "readOnlyHint": true, | ||
| "title": "Get notification details" | ||
| }, | ||
| "description": "Get detailed information for a specific GitHub notification, always call this tool when the user asks for details about a specific notification, if you don't know the ID list notifications first.", | ||
| "inputSchema": { | ||
| "properties": { | ||
| "notificationID": { | ||
| "description": "The ID of the notification", | ||
| "type": "string" | ||
| } | ||
| }, | ||
| "type": "object", | ||
| "required": [ | ||
| "notificationID" | ||
| ], | ||
| "type": "object" | ||
| "properties": { | ||
| "notificationID": { | ||
| "type": "string", | ||
| "description": "The ID of the notification" | ||
| } | ||
| } | ||
| }, | ||
| "name": "get_notification_details" | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,49 +1,49 @@ | ||
| { | ||
| "annotations": { | ||
| "title": "List notifications", | ||
| "readOnlyHint": true | ||
| "readOnlyHint": true, | ||
| "title": "List notifications" | ||
| }, | ||
| "description": "Lists all GitHub notifications for the authenticated user, including unread notifications, mentions, review requests, assignments, and updates on issues or pull requests. Use this tool whenever the user asks what to work on next, requests a summary of their GitHub activity, wants to see pending reviews, or needs to check for new updates or tasks. This tool is the primary way to discover actionable items, reminders, and outstanding work on GitHub. Always call this tool when asked what to work on next, what is pending, or what needs attention in GitHub.", | ||
| "inputSchema": { | ||
| "type": "object", | ||
| "properties": { | ||
| "before": { | ||
| "description": "Only show notifications updated before the given time (ISO 8601 format)", | ||
| "type": "string" | ||
| "type": "string", | ||
| "description": "Only show notifications updated before the given time (ISO 8601 format)" | ||
| }, | ||
| "filter": { | ||
| "type": "string", | ||
| "description": "Filter notifications to, use default unless specified. Read notifications are ones that have already been acknowledged by the user. Participating notifications are those that the user is directly involved in, such as issues or pull requests they have commented on or created.", | ||
| "enum": [ | ||
| "default", | ||
| "include_read_notifications", | ||
| "only_participating" | ||
| ], | ||
| "type": "string" | ||
| ] | ||
| }, | ||
| "owner": { | ||
| "description": "Optional repository owner. If provided with repo, only notifications for this repository are listed.", | ||
| "type": "string" | ||
| "type": "string", | ||
| "description": "Optional repository owner. If provided with repo, only notifications for this repository are listed." | ||
| }, | ||
| "page": { | ||
| "type": "number", | ||
| "description": "Page number for pagination (min 1)", | ||
| "minimum": 1, | ||
| "type": "number" | ||
| "minimum": 1 | ||
| }, | ||
| "perPage": { | ||
| "type": "number", | ||
| "description": "Results per page for pagination (min 1, max 100)", | ||
| "maximum": 100, | ||
| "minimum": 1, | ||
| "type": "number" | ||
| "maximum": 100 | ||
| }, | ||
| "repo": { | ||
| "description": "Optional repository name. If provided with owner, only notifications for this repository are listed.", | ||
| "type": "string" | ||
| "type": "string", | ||
| "description": "Optional repository name. If provided with owner, only notifications for this repository are listed." | ||
| }, | ||
| "since": { | ||
| "description": "Only show notifications updated after the given time (ISO 8601 format)", | ||
| "type": "string" | ||
| "type": "string", | ||
| "description": "Only show notifications updated after the given time (ISO 8601 format)" | ||
| } | ||
| }, | ||
| "type": "object" | ||
| } | ||
| }, | ||
| "name": "list_notifications" | ||
| } |
23 changes: 11 additions & 12 deletions
23
pkg/github/__toolsnaps__/manage_notification_subscription.snap
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,30 +1,29 @@ | ||
| { | ||
| "annotations": { | ||
| "title": "Manage notification subscription", | ||
| "readOnlyHint": false | ||
| "title": "Manage notification subscription" | ||
| }, | ||
| "description": "Manage a notification subscription: ignore, watch, or delete a notification thread subscription.", | ||
| "inputSchema": { | ||
| "type": "object", | ||
| "required": [ | ||
| "notificationID", | ||
| "action" | ||
| ], | ||
| "properties": { | ||
| "action": { | ||
| "type": "string", | ||
| "description": "Action to perform: ignore, watch, or delete the notification subscription.", | ||
| "enum": [ | ||
| "ignore", | ||
| "watch", | ||
| "delete" | ||
| ], | ||
| "type": "string" | ||
| ] | ||
| }, | ||
| "notificationID": { | ||
| "description": "The ID of the notification thread.", | ||
| "type": "string" | ||
| "type": "string", | ||
| "description": "The ID of the notification thread." | ||
| } | ||
| }, | ||
| "required": [ | ||
| "notificationID", | ||
| "action" | ||
| ], | ||
| "type": "object" | ||
| } | ||
| }, | ||
| "name": "manage_notification_subscription" | ||
| } |
29 changes: 14 additions & 15 deletions
29
pkg/github/__toolsnaps__/manage_repository_notification_subscription.snap
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,35 +1,34 @@ | ||
| { | ||
| "annotations": { | ||
| "title": "Manage repository notification subscription", | ||
| "readOnlyHint": false | ||
| "title": "Manage repository notification subscription" | ||
| }, | ||
| "description": "Manage a repository notification subscription: ignore, watch, or delete repository notifications subscription for the provided repository.", | ||
| "inputSchema": { | ||
| "type": "object", | ||
| "required": [ | ||
| "owner", | ||
| "repo", | ||
| "action" | ||
| ], | ||
| "properties": { | ||
| "action": { | ||
| "type": "string", | ||
| "description": "Action to perform: ignore, watch, or delete the repository notification subscription.", | ||
| "enum": [ | ||
| "ignore", | ||
| "watch", | ||
| "delete" | ||
| ], | ||
| "type": "string" | ||
| ] | ||
| }, | ||
| "owner": { | ||
| "description": "The account owner of the repository.", | ||
| "type": "string" | ||
| "type": "string", | ||
| "description": "The account owner of the repository." | ||
| }, | ||
| "repo": { | ||
| "description": "The name of the repository.", | ||
| "type": "string" | ||
| "type": "string", | ||
| "description": "The name of the repository." | ||
| } | ||
| }, | ||
| "required": [ | ||
| "owner", | ||
| "repo", | ||
| "action" | ||
| ], | ||
| "type": "object" | ||
| } | ||
| }, | ||
| "name": "manage_repository_notification_subscription" | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,25 +1,24 @@ | ||
| { | ||
| "annotations": { | ||
| "title": "Mark all notifications as read", | ||
| "readOnlyHint": false | ||
| "title": "Mark all notifications as read" | ||
| }, | ||
| "description": "Mark all notifications as read", | ||
| "inputSchema": { | ||
| "type": "object", | ||
| "properties": { | ||
| "lastReadAt": { | ||
| "description": "Describes the last point that notifications were checked (optional). Default: Now", | ||
| "type": "string" | ||
| "type": "string", | ||
| "description": "Describes the last point that notifications were checked (optional). Default: Now" | ||
| }, | ||
| "owner": { | ||
| "description": "Optional repository owner. If provided with repo, only notifications for this repository are marked as read.", | ||
| "type": "string" | ||
| "type": "string", | ||
| "description": "Optional repository owner. If provided with repo, only notifications for this repository are marked as read." | ||
| }, | ||
| "repo": { | ||
| "description": "Optional repository name. If provided with owner, only notifications for this repository are marked as read.", | ||
| "type": "string" | ||
| "type": "string", | ||
| "description": "Optional repository name. If provided with owner, only notifications for this repository are marked as read." | ||
| } | ||
| }, | ||
| "type": "object" | ||
| } | ||
| }, | ||
| "name": "mark_all_notifications_read" | ||
| } |
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
statewas not required before migration. But actually, the tool handler requires it.This is an acceptable change in the tool schema.