Migrate Repository Resources to the Go SDK #1457
Merged
+250
−615
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR migrates repository resource handlers from the mark3labs/mcp-go SDK to the new modelcontextprotocol/go-sdk. The migration updates API signatures, changes how URI templates are handled, and modifies how resource responses are structured.
Key Changes:
- Updated from old MCP SDK to the official Go SDK for MCP
- Changed URI parameter extraction from map-based arguments to URI template matching
- Restructured resource response types to use the new SDK's format
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 4 comments.
| File | Description |
|---|---|
| pkg/github/repository_resource.go | Migrates resource handler functions to use new SDK types, adds URI template constants, updates parameter extraction logic, changes base64 encoding approach |
| pkg/github/repository_resource_test.go | Updates test structure to work with new SDK types, removes URI template validation tests, adjusts test assertions for new response format |
SamMorrowDrums
approved these changes
Nov 20, 2025
Collaborator
SamMorrowDrums
left a comment
SamMorrowDrums
left a comment
There was a problem hiding this comment.
😎 AFAICT stays true to original intent and looks like a clean change. Nice one.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Migrates Repository Resources to the Go SDK.
Closes: https://github.com/github/copilot-agent-services/issues/922