text color equal to background color

[smeijer]

Some labels are rendered in the same color as the console background. Making them only readable after selecting the text.

Looking through the issues, I realize that can be because most of my labels don't have a background color.

Console: Cmder (ConEmu) @ Windows 10. The console does support 24bit color mode.

hub --version
git version 2.20.1.windows.1
hub version 2.11.2

---

From left to right, ConEmu, CMD, Powershell:

Repo from: #1980 (comment)

[mislav]

Hi thank you for reporting! This is how it should look like (iTerm2 on macOS):

Out detection of color compatibility in terminals isn't great https://github.com/github/hub/blob/dcdf56167c38eacef96ad5ef88575e7f74f9a6f2/utils/color.go#L113-L132

Do any of these terminals advertise TERM_PROGRAM among environment variables?

[smeijer]

Sorry, lost track of this issue. None of the terminals have the TERM_PROGRAM env variable. What should it's value be?

Shouldn't the purpose of adding --color be to ignore all kinds of terminal detection and force output in the 24bit color mode?

[smeijer]

Setting it to Apple_Terminal to force the "broken 24 bit mode" add's some color to it. As I understand it, setting it to anything else, would force render in 24bit mode. Correct? If that's the case, 24bit mode doesn't work on Windows. Which is strange, because ConEmu should support it.

set TERM_PROGRAM=Apple_Terminal
hub issue labels --color

[smeijer]

Cygwin and thereby ConEmu do expose the TERM env variable. It contains the value cygwin. Cmd and Powershell do not.

[mislav]

Thank you for exploring. Since these programs don't set TERM_PROGRAM, is there something else from the environment that we can detect and opt these shells into the "broken 24 bit mode"?