This repository was archived by the owner on Jun 8, 2023. It is now read-only.
Commit 7e51ea1
Justin Ellis
Actually adds the functionality that was attempted with commit 5f8a7bd. The problem with that code is that it is comparing two strings as if they are numbers, which does not work. For instance, if your jsdom.version is '0.10.1' then it will evaluate in the code as 'less than' '0.7.0', make an incorrect call to jsdom.env and nothing will work. I've added a quick and dirty, basic function to compare version number strings. It can certainly be improved upon, but should work well enough.
1 parent 9eedf8c commit 7e51ea1
1 file changed
+14
-1
lines changed| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
54 | 54 | | |
55 | 55 | | |
56 | 56 | | |
| 57 | + | |
| 58 | + | |
| 59 | + | |
| 60 | + | |
| 61 | + | |
| 62 | + | |
| 63 | + | |
| 64 | + | |
| 65 | + | |
| 66 | + | |
| 67 | + | |
| 68 | + | |
| 69 | + | |
57 | 70 | | |
58 | | - | |
| 71 | + | |
59 | 72 | | |
60 | 73 | | |
61 | 74 | | |
| |||
0 commit comments