classify XML files with .ncl extension as XML#4187
Merged
lildude merged 1 commit intogithub-linguist:masterfrom Jul 21, 2018
Merged
classify XML files with .ncl extension as XML#4187lildude merged 1 commit intogithub-linguist:masterfrom
lildude merged 1 commit intogithub-linguist:masterfrom
Conversation
pchaigno
suggested changes
Jul 9, 2018
Contributor
pchaigno
left a comment
pchaigno
left a comment
There was a problem hiding this comment.
Thanks @smola for fixing this!
We did not add a test in test_heuristics.rb for the .ncl heuristic rules at the time; could you add one now?
XML files with .ncl extensions were being classified as text.
Contributor
Author
|
👍 Done. |
lildude
approved these changes
Jul 21, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
When NCL support was added (see #2440), XML files with
.nclextension were classified as Text. This PR moves them to XML adding a simple heuristic.Tested on https://gist.github.com/pchaigno/2478bc86dd831382bfba by @pchaigno and, at least for the files that still exist today, this seems to be working correctly.
XML files with .ncl extensions were being classified as text.
Checklist: