Merged
Conversation
Contributor
|
Whoa! Thanks a lot @smola! Is there any heuristic rules for which you didn't add a test? If not, maybe we should add a test to make sure every heuristic rule has a corresponding test in |
Contributor
Author
|
I think I did cover everything, but I have to double-check. |
Contributor
Author
|
|
2 tasks
Contributor
|
Thanks @smola! I'll try to find some time to add a pedantic test to check all heuristic rules have a corresponding test. I'd really prefer we merge it at the same time as this pull request, otherwise we might need to redo a similar pull request in a few months. |
|
Ah shit, sorry, I just assumed this was a stale issue. Monday morning 😪 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
add more heuristics tests