Skip to content

Fix blatant lie in description of colour field#4247

Merged
lildude merged 1 commit intomasterfrom
markup-mixup
Aug 24, 2018
Merged

Fix blatant lie in description of colour field#4247
lildude merged 1 commit intomasterfrom
markup-mixup

Conversation

@Alhadis
Copy link
Collaborator

@Alhadis Alhadis commented Aug 24, 2018

A glaring mistake is sitting in plain sight in language.yml's description of the color field:

Only used if type is "programming" or "prose".

This should, of course, say markup, not prose. 😉

@Alhadis
Copy link
Collaborator Author

Alhadis commented Aug 24, 2018

@lildude I can't merge until CI passes its checks, and the failures are unrelated to this PR:

 1) Failure:
TestGrammars#test_submodules_have_approved_licenses [/home/travis/build/github/linguist/test/test_grammars.rb:115]:
The following submodules have unapproved licenses:
** 68-line list omitted for brevity **

What should I do?

@lildude
Copy link
Member

lildude commented Aug 24, 2018

What should I do?

Watch in awe as I whip out my admin rights and click the button...

@lildude lildude merged commit 7ff508e into master Aug 24, 2018
@lildude lildude deleted the markup-mixup branch August 24, 2018 09:22
@Alhadis
Copy link
Collaborator Author

Alhadis commented Aug 24, 2018

HAHA, you showoff. 😆

Thanks! 👍

@pchaigno pchaigno mentioned this pull request Aug 30, 2018
6 tasks
@github-linguist github-linguist locked as resolved and limited conversation to collaborators Jun 17, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants