Merged
Conversation
Charlock_holmes is struggling to build on Ruby 3
Alhadis
approved these changes
Jan 5, 2021
Collaborator
|
I'm starting to wonder if we shouldn't just replace This gem and its runtime dependencies have been the source of countless portability headaches over the years. I suspect Go's |
Member
Author
|
Yes, it would be nice to remove/replace |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
One Docker CI build has started failing because the default
alpineRuby version is now 3.0 and it appears charlock_holmes is having problems with this version of Ruby. From https://github.com/github/linguist/pull/5113/checks?check_run_id=1643086612This PR fixes our build and gets things working again for those using the Dockerfile by pinning the Ruby version to 2.x, which is inline with what we test Linguist against.