Skip to content

Comments

Add support for record-jar files#5182

Merged
lildude merged 5 commits intomasterfrom
record-jar
Feb 10, 2021
Merged

Add support for record-jar files#5182
lildude merged 5 commits intomasterfrom
record-jar

Conversation

@Alhadis
Copy link
Collaborator

@Alhadis Alhadis commented Feb 4, 2021

This pull-request adds support for the record-jar format, the best-known example of which (and the only one with sufficient distribution) is the IANA language subtag registry.

More background on this format can be found at a 7-year old repository of mine, which actually does a pretty good job of explaining it.

Distribution

Syntax highlighting samples

Origin of sample

Freely distributed by IANA and released to the public domain.

Rationale for colour choice

I picked #0673ba from IANA's logo, because record-jars (like most Unix text-file formats) don't have any "branding" so to speak.

@Alhadis Alhadis requested a review from a team as a code owner February 4, 2021 13:33
@lildude
Copy link
Member

lildude commented Feb 8, 2021

Origin of sample

Freely distributed by IANA and released to the public domain.

Whooopsie, looks like we're missing a commit as there isn't a sample on this PR at the mo 😉

@Alhadis
Copy link
Collaborator Author

Alhadis commented Feb 9, 2021

@lildude Whoops. Fixed.

@lildude
Copy link
Member

lildude commented Feb 9, 2021

Woah! It's hooog!! But I see it's pretty much the same file in every repo.

@lildude lildude merged commit 72efcaf into master Feb 10, 2021
@lildude lildude deleted the record-jar branch February 10, 2021 10:18
@Alhadis
Copy link
Collaborator Author

Alhadis commented Feb 18, 2021

Woah! It's hooog!! But I see it's pretty much the same file in every repo.

Holy hell, why didn't you tell me I was committing a 48,149-line sample??? :| That was supposed to be a cropped version of the database in the order of bytes, not minutes (spent waiting on your browser if you open the sample on GitHub). 😁

I'll make a note to remedy my brainfart later, because a 694.19 KB sample is simply unacceptable. Hell, 69.4 KB would've been unacceptable. Done. See #5272.

Promise me you'll kick my arse if I do that ever again. 😜

@lildude
Copy link
Member

lildude commented Feb 18, 2021

Promise me you'll kick my arse if I do that ever again. 😜

Promise 😆

Alhadis added a commit that referenced this pull request Mar 12, 2021
lildude pushed a commit that referenced this pull request Mar 15, 2021
@github-linguist github-linguist locked as resolved and limited conversation to collaborators Jun 17, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants