Add HIP language support#7334
Conversation
lildude
left a comment
There was a problem hiding this comment.
The sample you've provided is very small. I recommend adding a one or two more which are representative of the language as these files are used to train the classifier in the event another language with a matching extension is added in future. Small samples result in poor training data and thus poor analysis.
|
Thanks for the suggestion! I'll add a few more representative HIP samples to improve the training data and update the PR shortly. |
Added three representative HIP (.hip) files as language samples: - HelloWorld.hip - MatrixMultiplication.hip - PrefixSum.hip These are sourced from AMD's official ROCm HIP-Examples repository (MIT licensed) to improve classification accuracy and better represent real-world HIP usage.
lildude
left a comment
There was a problem hiding this comment.
Thanks for the new samples however several are too big - if they're suppressed in the diff, they're too big. We also don't accept "Hello world" samples as stated in the CONTRIBUTING.md file.
|
Thanks for the clarification! I'll replace the current samples with smaller, more representative ones from the same source and remove the HelloWorld sample per the CONTRIBUTING guidelines. Will update the PR shortly. I picked these from AMD’s official ROCm HIP-Examples repo to ensure they reflect real-world usage, but I understand the importance of size constraints and avoiding trivial examples. |
- Removed HelloWorld.hip and PrefixSum.hip as per CONTRIBUTING guidelines - Replaced MatrixMultiplication.hip with a reduced version under ~110 lines focusing on key HIP features: shared memory, kernel launch, and device memory
Description
This pull request adds support for the HIP programming language used in AMD's ROCm ecosystem for GPU programming. HIP is a C++-based parallel computing language, similar in structure to CUDA, and is widely used in projects targeting AMD GPUs.
.hipextension:#4F3A4Ftheme.
.hipextension is unique to HIP.Thanks for reviewing!