-
Couldn't load subscription status.
- Fork 248
Protocol conformance and spaces #24
Conversation
README.md
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you please use real attributes here? They're not important, but I think using something syntactically valid is a good idea.
It might also make sense to add an example with an explicit class, like:
@property (nonatomic, strong) NSObject<Protocol> *object;|
|
README.md
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think the more common id<Protocol> example would help. Perhaps also add that, where possible, extend a new protocol from the root <NSObject> protocol. That would be nice...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this example should include id<Protocol> and NSObject<Protocol> * (to show the two styles), which is what I meant by my original comment.
@galaxas0 This guide is not meant to be as exhaustive as you're suggesting. We only want to list items that are non-obvious, and extending <NSObject> is very common Cocoa convention.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@jspahrsummers Oh, alright, I did indeed misunderstand the extensiveness of this guide... thanks! 👍
|
This gets a 👍 from me. |
|
📬 |
|
Sorry it took so long to get back to you on this one. 📭 |
|
🐺 |
Protocol conformance and spaces
Any thoughts about the wording? Does this need the example it currently provides?
Fixes #22.