Skip to content

add Promise<void> to handlers return types #11

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 6, 2019
Merged

add Promise<void> to handlers return types #11

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions index.d.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@ export type SimpleResponse = {
}

export type RemoteFormHandler = (form: HTMLFormElement, kicker: Kicker, req: SimpleRequest) => void | Promise<void>;
export function afterRemote(fn: (form: HTMLFormElement) => void): void;
export function beforeRemote(fn: (form: HTMLFormElement) => void): void;
export function afterRemote(fn: (form: HTMLFormElement) => void | Promise<void>): void;
export function beforeRemote(fn: (form: HTMLFormElement) => void | Promise<void>): void;
export function remoteForm(selector: string, fn: RemoteFormHandler): void;
export function remoteUninstall(selector: string, fn: RemoteFormHandler): void;
4 changes: 2 additions & 2 deletions src/index.js.flow
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@ export type SimpleResponse = {
}
export type RemoteFormHandler = (form: HTMLFormElement, kicker: Kicker, req: SimpleRequest) => void | Promise<void>;

declare export function afterRemote(fn: (form: HTMLFormElement) => void): void;
declare export function beforeRemote(fn: (form: HTMLFormElement) => void): void;
declare export function afterRemote(fn: (form: HTMLFormElement) => void | Promise<void>): void;
declare export function beforeRemote(fn: (form: HTMLFormElement) => void | Promise<void>): void;
declare export function remoteForm(selector: string, fn: RemoteFormHandler): void;
declare export function remoteUninstall(selector: string, fn: RemoteFormHandler): void;