Skip to content

Remove outdated comment about bitmask compression #86

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 30, 2025
Merged

Remove outdated comment about bitmask compression #86

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 0 additions & 4 deletions crates/geo_filters/src/diff_count.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -393,8 +393,6 @@ impl<'a, C: GeoConfig<Diff> + Default> GeoDiffCount<'a, C> {
/// bitset of the geometric filter: 011010 101101 001010
/// repeated bit mask : 110100 110100 110100
/// masked bitset : 010000 100100 000000
/// after compression : 01 0 10 1 00 0
/// bitset of the returned filter : 010 101000
#[cfg(test)]
pub(crate) fn masked<C: GeoConfig<Diff>>(
diff_count: &GeoDiffCount<'_, C>,
Expand Down Expand Up @@ -608,8 +606,6 @@ mod tests {
// bitset of the geometric filter: 011010 101101 001010
// repeated bit mask : 110100 110100 110100
// masked bitset : 010000 100100 000000
// after compression : 01 0 10 1 00 0
// bitset of the returned filter : 010 101000
let m = GeoDiffCount7::from_ones([16, 15, 13, 11, 9, 8, 6, 3, 1]);
let n = masked(&m, 0b110100, 6);
assert_eq!(n.iter_ones().collect_vec(), vec![16, 11, 8]);
Expand Down