fix code scanning alerts #669
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
|
|
||
| // If not a glob pattern then just match the string. | ||
| if (!this.glob.includes('*')) { | ||
| this.regexp = new RegExp(`.*${this.glob}.*`, 'u') |
Check failure
Code scanning / CodeQL
Regular expression injection
| return | ||
| } | ||
| this.regexptText = this.globize(this.glob) | ||
| this.regexp = new RegExp(`^${this.regexptText}$`, 'u') |
Check failure
Code scanning / CodeQL
Regular expression injection
admtorgst
pushed a commit
to helse-sorost/safe-settings
that referenced
this pull request
Sep 14, 2024
* fix alerts * fix alerts * fix alerts * fix alerts * add tests and simplify Glob * fix import to lowercase file * removed debugging code
Contributor
|
@decyjphr These changes are making safe setting to malfunction and are implementing settings to the repos which are not configured via safe settings by reading from some file (in our case it picked one) from the suborg configuration. It has impacted 81 repos in our org. We have reverted these changes in our local version of safe settings for now. We had plans to invest time in fixing this. But just letting you know that this is not working as expected. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #668