Support uppercase environment variable names #676
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
klutchell
force-pushed
the
kyle/update-variables
branch
from
d4ad07f to
29995e7
Compare
Signed-off-by: Kyle Harding <kyle@balena.io>
There are still a bunch of errors like variable names that need to be resolved manually. Signed-off-by: Kyle Harding <kyle@balena.io>
Github REST API supports case-sensitive names on this endpoint so we should always create (POST) variables with the desired case. On subsequent GET, PATCH, and DELETE requests the Github REST API will use loose matching to find any existing objects, ignoring case. So in general we need to force to lowercase to perform diffs, and respect the provided case for create, but for all other calls it doesn't matter which case is used. Signed-off-by: Kyle Harding <kyle@balena.io>
klutchell
force-pushed
the
kyle/update-variables
branch
from
29995e7 to
0aaadf3
Compare
Contributor
Author
|
Not required if #682 is merged |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Github REST API supports case-sensitive names on this endpoint
so we should always create (POST) variables with the desired case.
On subsequent GET, PATCH, and DELETE requests the Github REST API
will use loose matching to find any existing objects, ignoring case.
So in general we need to force to lowercase to perform diffs, and respect
the provided case for create, but for all other calls it doesn't matter
which case is used.