Skip to content

Conversation

@nickmerwin
Copy link
Contributor

Here's the shiny new badge added to the README:

screen shot 2016-02-05 at 11 13 04 am

And the coverage tracking:

screen shot 2016-02-05 at 11 08 40 am

Currently here but we'll move it to the proper repo url after merging.

Thanks!

@natesholland
Copy link
Contributor

I like the idea! For some reason bundler failed in Ruby 2.1.8 building native extensions.

@nickmerwin
Copy link
Contributor Author

Hey @natesholland I'm finding some evidence that this is an issue with Travis:
https://travis-ci.org/bundler/bundler/jobs/76333985
https://travis-ci.org/rails/web-console/jobs/104453431

I'll keep researching the cause.

@nickmerwin
Copy link
Contributor Author

@natesholland aha! I was able to fix that issue by explicitly including the missing apt package in .travis.yml:

addons:
 apt:
   packages:
     - libgmp-dev

@johana-star
Copy link

Is there anything blocking this PR from being merged?

@jbarnette
Copy link
Contributor

@strand Thank you for the ping early this year, I'm sorry I missed it!

@nickmerwin Hello from the future, several hundred years after you opened this PR. 🙀 I love calling out coverage in the README. You still 👍 on merging this?

@nickmerwin
Copy link
Contributor Author

@jbarnette hello fellow future traveler! Good to go 👍

@jbarnette jbarnette merged commit ee51cd1 into github:master Aug 11, 2017
@jbarnette
Copy link
Contributor

@nickmerwin 🚀 Will you switch coveralls to the proper repo when you have a sec?

@nickmerwin
Copy link
Contributor Author

@jbarnette done! 🎉

Also, we should make your user the owner of the repo so PR status API calls can be made with your OAuth token -- you'd just need to log into Coveralls and then I can update it. Let me know, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants