fix: Skip CLI checks for IDE-based agents in check command #929
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Add requires_cli field handling to check() command - IDE-based agents (copilot, cursor-agent, windsurf, kilocode, roo) now properly skip CLI checks - Prevents false errors when checking for IDE-integrated agents that don't require CLI tools
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR fixes the CLI checking logic for IDE-based agents in the check command by properly handling the requires_cli field from agent configuration. It prevents false negative errors when checking for agents that are integrated directly into IDEs and don't require separate CLI tool installations.
- Add
requires_clifield handling to skip CLI checks for IDE-based agents - Mark IDE-based agents as skipped rather than failed when they don't have CLI tools
- Set IDE-based agent results to
Falseto exclude them from "found" tool counts
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
localden
approved these changes
Oct 19, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed #926.
This PR will show below that will help us have more insight from agent supportability.