Remove feature flag guard around source archive jump-to-definition #368
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shati-patel
reviewed
May 14, 2020
extensions/ql-vscode/CHANGELOG.md
Outdated
Comment on lines
5
to
6
| - Add CodeQL-query-powered handlers for 'Go to Definition' and 'Go To | ||
| References' on source archive files. |
Contributor
There was a problem hiding this comment.
Suggested change
| - Add CodeQL-query-powered handlers for 'Go to Definition' and 'Go To | |
| References' on source archive files. | |
| - Enable 'Go to Definition' and 'Go to References' on source archive files | |
| in CodeQL databases. This is handled by a CodeQL query. |
Suggestion to make this a bit clearer?
Contributor
Author
There was a problem hiding this comment.
Ok, sounds good! That change of emphasis makes sense now that you point it out.
aeisenberg
reviewed
May 15, 2020
extensions/ql-vscode/src/config.ts
Outdated
|
|
||
| /** | ||
| * This setting is deliberately not in package.json so that it does | ||
| * Any settings below deliberately not in package.json so that they do |
Contributor
There was a problem hiding this comment.
Nit: there's a grammatical error here.
aeisenberg
requested changes
May 15, 2020
Contributor
aeisenberg
left a comment
aeisenberg
left a comment
There was a problem hiding this comment.
Looks good, after addressing @shati-patel's change.
Contributor
Docs update is done! We can publish that any time, just let me know when you plan to release. |
jcreedcmu
force-pushed
the
jcreed/jump-to-def-release
branch
from
96e5943 to
a98e3bc
Compare
Contributor
Author
|
Should wait until after 1.1.5 release before merging this, just so I can rebase onto the CHANGELOG changes. |
aeisenberg
previously approved these changes
May 19, 2020
aeisenberg
previously approved these changes
May 19, 2020
aeisenberg
approved these changes
May 19, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
@github/product-docs-dsphas been notified, we probably want to wait on https://github.com/github/semmle-docs/issues/5 before merging this.