Skip to content

Bump eslint-plugin-react-hooks from 5.2.0 to 7.0.1 in /extensions/ql-vscode #4182

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Oct 30, 2025
Merged

Bump eslint-plugin-react-hooks from 5.2.0 to 7.0.1 in /extensions/ql-vscode #4182

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
6c81a71
Bump eslint-plugin-react-hooks in /extensions/ql-vscode
dependabot[bot] Oct 30, 2025
2d75753
Fix eslint-plugin-react-hooks 7.0.1 compatibility (#4186)
Copilot Oct 30, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
26 changes: 24 additions & 2 deletions extensions/ql-vscode/eslint.config.mjs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -113,7 +113,7 @@ export default tseslint.config(
extends: [
react.configs.flat.recommended,
react.configs.flat['jsx-runtime'],
reactHooks.configs['recommended-latest'],
reactHooks.configs.flat['recommended-latest'],
storybook.configs['flat/recommended'],
github.getFlatConfigs().react,
],
Expand All @@ -122,6 +122,10 @@ export default tseslint.config(
version: "detect",
},
},
rules: {
// Disable new strict rules from eslint-plugin-react-hooks 7.0.1 that fail with current codebase
"react-hooks/set-state-in-effect": "off",
},
},
{
files: ["src/view/**/*"],
Expand All @@ -133,14 +137,32 @@ export default tseslint.config(
extends: [
react.configs.flat.recommended,
react.configs.flat['jsx-runtime'],
reactHooks.configs['recommended-latest'],
reactHooks.configs.flat['recommended-latest'],
github.getFlatConfigs().react,
],
settings: {
react: {
version: "detect",
},
},
rules: {
// Disable new strict rules from eslint-plugin-react-hooks 7.0.1 that fail with current codebase
"react-hooks/set-state-in-effect": "off",
"react-hooks/refs": "off",
"react-hooks/purity": "off",
"react-hooks/error-boundaries": "off",
},
},
{
// Special case for files using custom useEffectEvent implementation
files: [
"src/view/common/SuggestBox/useOpenKey.ts",
"src/view/common/SuggestBox/__tests__/useEffectEvent.test.ts",
],
rules: {
"react-hooks/rules-of-hooks": "off",
"react-hooks/exhaustive-deps": "off",
},
},
{
files: ["test/vscode-tests/**/*"],
Expand Down
57 changes: 52 additions & 5 deletions extensions/ql-vscode/package-lock.json
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion extensions/ql-vscode/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2105,7 +2105,7 @@
"eslint-plugin-jest-dom": "^5.5.0",
"eslint-plugin-prettier": "^5.2.6",
"eslint-plugin-react": "^7.37.5",
"eslint-plugin-react-hooks": "^5.2.0",
"eslint-plugin-react-hooks": "^7.0.1",
"eslint-plugin-storybook": "^9.0.12",
"glob": "^11.0.1",
"gulp": "^5.0.0",
Expand Down