Skip to content

fix: pin AWF container images to specific firewall version#30

Merged
jamesadevine merged 1 commit intomainfrom
fixup-docker-pull
Mar 16, 2026
Merged

fix: pin AWF container images to specific firewall version#30
jamesadevine merged 1 commit intomainfrom
fixup-docker-pull

Conversation

@jamesadevine
Copy link
Collaborator

Pulls versioned Docker images (e.g. \ghcr.io/.../squid:v0.5.0) instead of :latest\ to ensure reproducible builds, then tags them as :latest\ for backward compatibility with AWF.

This prevents silent breakage when upstream images are updated.

Pull versioned Docker images instead of :latest to ensure reproducible
builds, then tag them as :latest for backward compatibility with AWF.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
@jamesadevine jamesadevine merged commit bb92c9c into main Mar 16, 2026
3 checks passed
@github-actions
Copy link
Contributor

🔍 Rust PR Review

Summary: Looks good — clean, correct change with no issues.

Findings

✅ What Looks Good

  • Correct version source: {{ firewall_version }} maps to the AWF_VERSION constant ("0.23.1") in src/compile/common.rs, so the pulled image tag (v0.23.1) is guaranteed to match the AWF binary downloaded just above it in the same pipeline step. No version skew possible.
  • Symmetric update: Both occurrences in templates/base.yml (the PerformAgenticTask job and the ProcessSafeOutputs job) are updated identically — no missed site.
  • docker tag rationale is sound: Re-tagging the pinned image as :latest is the right pattern when AWF references its own container images by the :latest tag internally. Avoids having to patch AWF's internals.
  • Security improvement: Pulling by digest-equivalent versioned tag eliminates silent breakage from upstream image mutations — a real supply-chain risk with :latest.

No bugs, logic issues, or security concerns found.

Generated by Rust PR Reviewer for issue #30 ·

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant