fix(tests): strengthen checksum verification assertion against regression#48
Merged
jamesadevine merged 2 commits intomainfrom Mar 17, 2026
Merged
Conversation
…ssion Co-authored-by: jamesadevine <4742697+jamesadevine@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Fix checksum test assertion to guard against regression
fix(tests): strengthen checksum verification assertion against regression
Mar 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The positive-only checksum assertion would pass even with the old regressed pattern (
sha256sum -c checksums.txt --ignore-missing | grep -q ": OK"), since it's a substring match.Changes
tests/compiler_tests.rs: Add a negative assertion alongside the existing positive check to explicitly reject thegrep -qpipe pattern:Original prompt
📱 Kick off Copilot coding agent tasks wherever you are with GitHub Mobile, available on iOS and Android.