Skip to content

fix(compile): tighten ADO org name validation to alphanumeric and hyphen only#598

Merged
jamesadevine merged 5 commits into
mainfrom
copilot/update-nuget-authenticate-command
May 17, 2026
Merged

fix(compile): tighten ADO org name validation to alphanumeric and hyphen only#598
jamesadevine merged 5 commits into
mainfrom
copilot/update-nuget-authenticate-command

Conversation

@jamesadevine
Copy link
Copy Markdown
Collaborator

Summary

Test plan

github-actions Bot and others added 3 commits May 17, 2026 12:53
… command field

- README.md: add missing `enable` command to CLI Reference section
- docs/template-markers.md: update `{{ engine_install_steps }}` to describe
  target-aware install strategy (NuGet for 1ES, GitHub Releases for others)
- docs/engine.md: clarify `command` field description — skips the default
  engine binary installation which is NuGet for 1ES targets but GitHub
  Releases for standalone/job/stage targets

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
…dcoded msazuresphere

Agent-Logs-Url: https://github.com/githubnext/ado-aw/sessions/e1c74427-9ecf-4ff6-b925-4822facdd4de

Co-authored-by: jamesadevine <4742697+jamesadevine@users.noreply.github.com>
…hen only

Agent-Logs-Url: https://github.com/githubnext/ado-aw/sessions/e1c74427-9ecf-4ff6-b925-4822facdd4de

Co-authored-by: jamesadevine <4742697+jamesadevine@users.noreply.github.com>
@jamesadevine
Copy link
Copy Markdown
Collaborator Author

@copilot resolve the merge conflicts in this pull request

jamesadevine and others added 2 commits May 17, 2026 17:19
…fecycle commands (#601)

- docs/template-markers.md: correct {{ engine_log_dir }} from ~/.copilot/logs to
  $HOME/.copilot/logs, matching src/engine.rs log_dir(). Add explanation that tilde
  does not expand inside double-quoted bash strings, which would cause the directory
  check to always fail and silently prevent log collection.
- AGENTS.md: remove references to unimplemented lifecycle CLI commands (disable,
  remove, list, run, status, secrets) from the ado/mod.rs description; only the
  'enable' command is currently implemented.

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Co-authored-by: jamesadevine <4742697+jamesadevine@users.noreply.github.com>
…authenticate-command

Co-authored-by: jamesadevine <4742697+jamesadevine@users.noreply.github.com>
Copy link
Copy Markdown
Contributor

Copilot AI commented May 17, 2026

@copilot resolve the merge conflicts in this pull request

Resolved. The conflict was in docs/template-markers.md — both main and our branch modified the {{ engine_install_steps }} section from the same base. Merged origin/main into the branch and kept our fix (user's ADO org instead of hardcoded msazuresphere). Commit bfa2061.

@jamesadevine jamesadevine merged commit 91d39a9 into main May 17, 2026
@jamesadevine jamesadevine deleted the copilot/update-nuget-authenticate-command branch May 17, 2026 17:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants