fix(secrets): preserve masked ADO secrets on definition PUT#604
Merged
Conversation
Agent-Logs-Url: https://github.com/githubnext/ado-aw/sessions/82cb744f-2971-4d38-abb1-d81eddf5d41f Co-authored-by: jamesadevine <4742697+jamesadevine@users.noreply.github.com>
Copilot created this pull request from a session on behalf of
jamesadevine
May 17, 2026 22:02
View session
jamesadevine
approved these changes
May 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ADO build-definition
GETresponses mask existing secret variables as***. Whensecrets setround-tripped the full definition viaPUT, those masked siblings could be written back literally, replacing real stored secrets.Preserve masked secret siblings
{"isSecret": true, "value": "***"}tovalue: nullbefore any definitionPUT.Apply the fix across definition round-trips
secrets setsecrets deleteenable --also-set-tokenPUTdefinitions backDocument the ADO-specific behavior
docs/cli.mdforsecrets setdescribing why masked secrets are normalized beforePUT.{ "SECRET_A": { "isSecret": true, "value": null }, "SECRET_B": { "isSecret": true, "value": "new-value" } }Test plan
Covered by targeted unit coverage for masked-secret normalization and existing repo validation.