fix(site): restore correct --sl-color-black in light mode for search box contrast#646
Merged
Merged
Conversation
…box contrast Agent-Logs-Url: https://github.com/githubnext/ado-aw/sessions/450f8317-4c5f-4a92-ac6d-c549d6577d12 Co-authored-by: jamesadevine <4742697+jamesadevine@users.noreply.github.com>
Copilot created this pull request from a session on behalf of
jamesadevine
May 19, 2026 12:16
View session
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Starlight maps
--pagefind-ui-background: var(--sl-color-black)for the search modal. In Starlight's theming system the gray scale is inverted between modes, so--sl-color-blackmust be#ffffffin light mode (the background endpoint). The custom CSS was setting it to#1f2328(near-black) — same value as--sl-color-text— producing an illegible black-on-black search modal in light mode.Fix: one-line change in
site/src/styles/custom.css:--sl-color-textis unchanged; body text contrast is unaffected.Test plan
Verified locally by inspecting the compiled CSS variable resolution:
--pagefind-ui-backgroundnow resolves to#ffffffin light mode, with--pagefind-ui-textresolving via--sl-color-gray-2tohsl(224, 10%, 23%)— correct contrast.