fix: YAML path matching and legacy SSH URL support

[jamesadevine]

Summary

Follow-up bug fixes from PR #92 review feedback.

Bug Fix

• YAML path matching always failed — ADO stores \yamlFilename\ with a leading /\ (e.g., /.azdo/pipelines/agent.yml), but the local detection produces relative paths without it. Every pipeline silently fell through to fuzzy name matching, emitting spurious warnings even for correctly-configured pipelines. Fixed by stripping the leading /\ before comparison.

Improvements

• Legacy SSH URL support — Added \git@vs-ssh.visualstudio.com:v3/\ as an accepted SSH remote prefix, matching the older ADO SSH format still in wide use.
• Step numbering — Fixed comment numbering in
  un()\ that jumped from Step 3 to Step 5.

Tests

3 new tests: legacy SSH URL parsing, YAML path matching with and without leading slash. All 452 tests pass.

[github-actions]

🔍 Rust PR Review

Summary: Looks good — two targeted bug fixes with appropriate tests, but the YAML path tests have a structural issue that reduces their effectiveness.

Findings

⚠️ Suggestions

• src/configure.rs:700–731 — The two YAML path tests (test_yaml_path_match_strips_leading_slash and test_yaml_path_match_without_leading_slash) duplicate the normalization logic inline rather than exercising the production code path in match_definitions. If someone later modifies the normalization in the closure (e.g., accidentally removes trim_start_matches('/')) these tests would still pass, providing false confidence.

  The fix is to either extract the normalization into a named helper:

  fn normalize_ado_yaml_path(path: &str) -> String {
      path.trim_start_matches('/').replace('\\', "/")
  }

  …and call it in both the production closure and the tests, or to write the tests around a path_match assertion using the full MatchedDefinition result (which would require a bit more setup but would actually exercise the matching logic end-to-end).

• src/configure.rs:30–34 — The doc comment for parse_ado_remote lists three supported URL formats but doesn't mention the newly added legacy SSH format (git@vs-ssh.visualstudio.com:v3/…). Worth adding for completeness:

  /// - SSH (legacy): `git@vs-ssh.visualstudio.com:v3/{org}/{project}/{repo}`
  

✅ What Looks Good

• The or_else chain for the SSH prefix variants is clean and correct — no code duplication, both formats share the same splitn/trim_end_matches path.
• trim_start_matches('/') is correctly more permissive than strip_prefix('/') — handles any number of leading slashes without issue.
• make_def_with_yaml helper avoids repetition across the new path-matching tests.
• The legacy SSH test covers the expected org_url → `(dev.azure.com/redacted) remapping correctly.
• No unwrap()/expect() on user-facing paths; error handling patterns are unchanged and consistent with the rest of the file.

Generated by Rust PR Reviewer for issue #95 · ◷

[github-actions]

🔍 Rust PR Review

Summary: Looks good — clean, targeted bug-fix with solid test coverage. All 27+ tests pass.

Findings

✅ What Looks Good

• Legacy SSH URL support (git@vs-ssh.visualstudio.com:v3/...): The or_else() chaining on strip_prefix is idiomatic Rust and correctly reuses the existing parse path. The org_url is normalised to (dev.azure.com/redacted) regardless of which SSH variant is used — consistent with how HTTPS legacy ({org}.visualstudio.com`) is handled.

• normalize_ado_yaml_path extraction: Good refactoring. Previously the backslash normalisation was inlined in two slightly different places — the ADO side (is_some_and closure) lacked the leading-slash strip while the local side always produced a relative path. Extracting to a named helper makes the asymmetry intentional and documented.

• Operation order in the helper (replace before trim_start_matches): Correct — a Windows path like \.azdo\file.yml must have its backslashes converted to / first, otherwise trim_start_matches('/') would miss the leading \.

• Step numbering fix (5 → 4): Minor but welcome; the sequence was 1, 2, 3, 5 in the original.

• Test coverage: Three focused unit tests for normalize_ado_yaml_path (with slash, without slash, backslash) and a dedicated test for the new SSH URL variant.

⚠️ Suggestions

• src/configure.rs:305 — The local-side normalisation still duplicates the backslash-replace logic inline: yaml_path_str.replace('\\', "/"). Since normalize_ado_yaml_path now owns that logic for the ADO side, consider a separate small helper (or rename/broaden the existing one) so both sides use the same function. This is cosmetic for now since local paths shouldn't carry a leading /, but it removes the subtle asymmetry.

• src/configure.rs:278 — trim_start_matches('/') strips all leading slashes (e.g. //path → path). ADO typically emits exactly one, so this is fine and arguably more robust — just worth a one-word comment if this ever surprises a reviewer (// strip one or more leading slashes).

Generated by Rust PR Reviewer for issue #95 · ◷

Warning

⚠️ Firewall blocked 1 domain

The following domain was blocked by the firewall during workflow execution:

• dev.azure.com

To allow these domains, add them to the network.allowed list in your workflow frontmatter:

network:
  allowed:
    - defaults
    - "dev.azure.com"

See Network Configuration for more information.