Lpcox/fix launcher tests #446
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The JSON schema now requires 'container' instead of 'command' for stdio servers. This change updates all launcher tests to use a new helper function 'newTestConfig' that creates config directly without schema validation, allowing tests to continue testing internal behavior with arbitrary command configurations. Changes: - Add newTestConfig helper in launcher_test.go for creating test configs directly without JSON parsing/schema validation - Update all getorlaunch_stdio_test.go tests to use newTestConfig - Keep TestGetOrLaunch_ContainerFieldConversion using loadConfigFromJSON since it tests the actual schema-compliant config conversion - Add apiKey to gateway config in ContainerFieldConversion test to satisfy schema requirements
…s documentation - Fix evaluator.go: secrecy checks were swapped between read and write - Read secrecy: resource.Secrecy.CheckFlow(agentSecrecy) for R ⊆ A - Write secrecy: agentSecrecy.CheckFlow(&resource.Secrecy) for A ⊆ R - Fix evaluator_test.go: ReadWrite test needed matching secrecy tags - Add internal/difc/DIFC_RULES.md: comprehensive reference for DIFC rules - Core rules with mathematical notation - Examples for common scenarios - Implementation notes on CheckFlow semantics - Testing guidelines for agents
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.