-
Notifications
You must be signed in to change notification settings - Fork 28
Closed
Labels
Description
Objective
Update pkg/workflow/copilot_engine.go to use the unified MCPConfigRenderer instead of duplicated rendering functions.
Context
CopilotEngine currently has 4 duplicated MCP rendering functions with Copilot-specific fields (e.g., includeCopilotFields). These should be replaced with calls to the unified renderer. Related to #3942.
Approach
- Update
copilot_engine.goto useNewMCPConfigRenderer()with Copilot-specific options - Replace these functions with unified renderer calls:
renderGitHubCopilotMCPConfig()→ Userenderer.RenderGitHubMCP()renderPlaywrightCopilotMCPConfig()→ Userenderer.RenderPlaywrightMCP()renderSafeOutputsCopilotMCPConfig()→ Userenderer.RenderSafeOutputsMCP()renderAgenticWorkflowsCopilotMCPConfig()→ Userenderer.RenderAgenticWorkflowsMCP()
- Configure renderer options with
IncludeCopilotFields: true - Update tests to verify Copilot-specific behavior is preserved
Files to Modify
pkg/workflow/copilot_engine.go- Update to use unified rendererpkg/workflow/copilot_engine_test.go- Update tests if needed
Acceptance Criteria
- All 4 Copilot MCP rendering functions replaced with unified renderer calls
- CopilotEngine configured with
IncludeCopilotFields: trueoption - All existing tests pass without modification to expected behavior
- Code compiles without errors
- No duplicate rendering logic remains in copilot_engine.go
- Copilot-specific fields are correctly included in MCP configuration output
Related to [refactor] 🔧 Semantic Function Clustering Analysis: Refactoring Opportunities #3942
AI generated by Plan Command for #3942
Copilot