Skip to content

[security-fix] Security Fix: Allocation Size Overflow in Domain List Merging (Alert #6) #1528

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Oct 11, 2025
Merged

[security-fix] Security Fix: Allocation Size Overflow in Domain List Merging (Alert #6) #1528

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
15f546b
Security Fix: Allocation Size Overflow in Domain List Merging (Alert #6)
github-actions[bot] Oct 11, 2025
20aecf6
Add changeset for security fix: allocation overflow in domain list me…
github-actions[bot] Oct 11, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions .changeset/patch-fix-allocation-overflow-mcp-domain-merging.md
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

7 changes: 6 additions & 1 deletion pkg/parser/mcp.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,12 @@ func EnsureLocalhostDomains(domains []string) []string {
}
}

result := make([]string, 0, len(domains)+4)
// CWE-190: Allocation Size Overflow Prevention
// Instead of pre-calculating capacity (len(domains)+4), which could overflow
// if domains is extremely large, we let Go's append handle capacity growth
// automatically. This is safe and efficient for domain arrays which are
// typically small in practice.
var result []string

// Always add localhost domains first (with and without port specifications)
if !hasLocalhost {
Expand Down
Loading