Enhance timestamp and token usage extraction for Codex format in logs #17
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dsyme
approved these changes
Aug 13, 2025
pelikhan
added a commit
that referenced
this pull request
Aug 23, 2025
…ation (#17) (#206) * Initial plan * Implement engine-declared output artifact support - Add GetDeclaredOutputFiles() method to AgenticEngine interface - Claude engine declares output.txt as output file - Codex engine declares no output files (empty list) - Compiler conditionally generates output steps only for engines with declared outputs - Add OutputArtifactName constant for consistent artifact naming - Update prompt generation and environment variables to be conditional - Add comprehensive tests for engine capabilities and conditional compilation * Final cleanup and test improvements - Use OutputArtifactName constant in tests for consistency - Add fmt import to agentic_output_test.go - Ensure all tests pass with updated constant references * Fix engine output collection to preserve GITHUB_AW_OUTPUT for all engines - GITHUB_AW_OUTPUT functionality is now preserved for ALL engines (Claude and Codex) - Engine-declared output files are collected separately as "agent_outputs" artifact - Only engines that declare output files (like Claude with "output.txt") get engine output collection steps - Codex engine continues to use GITHUB_AW_OUTPUT but doesn't get engine output collection since it declares no output files - The GITHUB_AW_OUTPUT artifact remains named "aw_output.txt" as before - Engine-declared files are collected in a separate "agent_outputs" artifact as requested * Move engine output collection to separate file and simplify implementation --------- Co-authored-by: Copilot <198982749+Copilot@users.noreply.github.com> Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Improve the extraction of timestamps and token usage from logs formatted in Codex style. This includes adding support for timestamps without a 'Z' suffix and introducing new patterns for token usage. Additionally, implement tests to validate the handling of Codex format logs.