- 
                Notifications
    
You must be signed in to change notification settings  - Fork 22
 
[WIP] Recompile and fix Agentic workflows permissions #2789
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>
Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>
…orkflows-permissions
- Modified permissions across multiple workflows to include 'issues' and 'pull-requests' while removing 'actions' where applicable. - Changed the runtime environment from 'ubuntu-latest' to 'ubuntu-slim' for improved efficiency in various workflows. - Ensured consistency in permission settings for workflows related to issue classification, logging, and analysis. - Enhanced security and functionality by adding necessary permissions for discussions and security events in relevant workflows.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR fixes permission issues in agentic workflows that use safe-outputs and recompiles all workflows to generate updated lock files. The main issue was that workflows using the safe-outputs system were incorrectly including write permissions in their frontmatter, when those permissions should be removed since safe-outputs handles write operations in separate jobs.
- Corrected permissions in 
schema-consistency-checker.mdby removingdiscussions: writeandread-only: false - Updated all workflow permissions to replace 
actions: readwith specific permissions likeissues: readandpull-requests: read - Recompiled all workflows to reflect the permission changes and infrastructure updates
 
Reviewed Changes
Copilot reviewed 62 out of 62 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description | 
|---|---|
pkg/workflow/schemas/github-workflow.json | 
Formatted enum arrays for better readability | 
schema-consistency-checker.md | 
Fixed safe-outputs permissions issue by removing write permissions | 
Various .md workflow files | 
Updated permissions from actions: read to specific read permissions | 
Various .lock.yml files | 
Recompiled workflows with updated permissions and infrastructure changes | 
.github/aw/actions-lock.json | 
Added new GitHub Script action version | 
Comments suppressed due to low confidence (1)
.github/workflows/schema-consistency-checker.md:1
- The 
read-only: falseconfiguration was correctly removed as it conflicts with safe-outputs usage. When usingsafe-outputs: create-discussion, the main job should not have write permissions since safe-outputs handles write operations in a separate job. 
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Recompile and Fix Agentic Workflows Permissions
Summary
Fix permission issues in agentic workflows that use safe-outputs, then recompile all workflows to generate updated lock files.
Checklist
Issue Found
The
schema-consistency-checker.mdworkflow has:discussions: writepermission in frontmatter (line 9)read-only: falsefor GitHub tools (line 16)Both should be removed when using
safe-outputs: create-discussionsince the safe-outputs system handles write operations in a separate job with appropriate permissions.Original prompt
💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.