-
Notifications
You must be signed in to change notification settings - Fork 28
Fix Docker registry access blocking in mcp-inspector workflow #3640
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
@copilot continue |
Fixes docker.io blocking by adding the containers ecosystem identifier to the network configuration. This allows the workflow to pull Docker images for its 6 container-based MCP servers (arxiv, ast-grep, brave, context7, notion, server-memory). Resolves #3609 Related to #3607 Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>
Fixed in commit 7a16080. Updated The workflow now allows access to Docker Hub, GitHub Container Registry, Microsoft Container Registry, and Quay, enabling all 6 container-based MCP servers (arxiv, ast-grep, brave, context7, notion, server-memory) to function properly. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR fixes Docker registry access blocking in the mcp-inspector.md workflow by adding the containers ecosystem identifier to the network configuration. The workflow uses firewall protection and imports 6 container-based MCP servers (arxiv, ast-grep, brave, context7, notion, server-memory) that require pulling Docker images, but was missing the network permission to access Docker registries.
Key changes:
- Added
allowed: [defaults, containers]to the network configuration inmcp-inspector.md - The compiled lock.yml correctly expands the
containersecosystem to all necessary Docker registry domains
Impact:
Resolves the 7 docker.io blocking events reported in Discussion #3607 by allowing the workflow to pull Docker images from container registries including Docker Hub, GitHub Container Registry, Quay, and Microsoft Container Registry.
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
.github/workflows/mcp-inspector.md |
Added network.allowed configuration with defaults and containers ecosystems to enable Docker registry access |
.github/workflows/mcp-inspector.lock.yml |
Compiled workflow with expanded domain list including all container registry domains (*.docker.io, registry.hub.docker.com, ghcr.io, quay.io, gcr.io, mcr.microsoft.com, etc.) |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Task: Audit Workflows Blocking Docker Registry Access
This PR identifies and fixes workflows with firewall enabled that block
docker.ioand need container registry access.Completed Checklist
containersecosystemChanges Made
Updated
.github/workflows/mcp-inspector.mdto add thecontainersecosystem identifier:This enables the workflow to access:
docker.io,registry.hub.docker.com)ghcr.io)mcr.microsoft.com)quay.io)Executive Summary
Fixed 1 workflow that was blocking docker.io:
containersin network config12 workflows correctly configured - Have firewall enabled but don't use containers
Key Findings
Container-based MCP servers (7):
mcp/arxiv-mcp-servermcp/ast-grepmcr.microsoft.com/azure-sdk/azure-mcp(commented out)docker.io/mcp/brave-searchmcp/context7mcp/notionmcp/memoryThe mcp-inspector.md workflow:
network.firewall: truecontainersecosystem in network.allowedImpact
This fix resolves the 7
docker.ioblocking events reported in Discussion #3607. The mcp-inspector workflow will now successfully pull Docker images and initialize all its container-based MCP servers.Resolves #3609
Related to #3607
Original prompt
💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.