Skip to content

Conversation

@dsyme
Copy link
Contributor

@dsyme dsyme commented Nov 15, 2025

Summary

  • Refactored workflow disabling logic to work correctly in clone-repo mode
  • Improved directory management when disabling workflows
  • Removed unnecessary debug logging

Details

The changes modify the RunWorkflowTrials function to:

  • Move workflow disabling logic to a more appropriate location
  • Ensure correct directory context when disabling workflows
  • Handle directory changes safely with proper error checking
  • Remove debug print statements

Copilot AI review requested due to automatic review settings November 15, 2025 00:11
Copilot finished reviewing on behalf of dsyme November 15, 2025 00:13
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR fixes a critical bug in the workflow disabling logic for the trial command's clone-repo mode. The workflow disabling operation was previously attempting to work on the remote repository before it was cloned locally, causing it to fail. The fix relocates this logic to execute after the local clone is created and uses proper directory context switching to operate on the local filesystem.

Key changes:

  • Relocated workflow disabling logic from Step 2.7 (after remote content cloning) to Step 3.5 (after local host repository cloning)
  • Implemented safe directory context switching to work on the local clone instead of attempting remote API operations
  • Removed unnecessary debug logging statement in determineAndAddEngineSecret function

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@dsyme dsyme merged commit ed17fb5 into main Nov 15, 2025
47 checks passed
@dsyme dsyme deleted the dwq branch November 15, 2025 00:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants