Skip to content

Conversation

@dsyme
Copy link
Contributor

@dsyme dsyme commented Nov 15, 2025

Summary

  • Moved workflow disabling logic earlier in the RunWorkflowTrials function
  • Improved error handling and temporary directory management for workflow disabling
  • Simplified workflow disabling process in clone-repo mode

Changes

  • Relocated workflow disabling step to occur before trial execution
  • Added separate temporary directory clone for workflow disabling
  • Maintained existing warning-level error handling for non-critical workflow disabling failures

Copilot AI review requested due to automatic review settings November 15, 2025 01:55
Copilot finished reviewing on behalf of dsyme November 15, 2025 01:58
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This pull request optimizes the trial command by moving the workflow disabling logic earlier in the execution flow, from inside the runAllTrials function to before it. This ensures workflows are disabled only once rather than per trial iteration when using --repeat.

Key Changes

  • Workflow disabling now occurs at Step 2.8, immediately after cloning repository contents (Step 2.7)
  • A separate temporary directory clone (tempDirForDisable) is created specifically for the workflow disabling operation
  • Error handling maintains the existing warning-level approach for non-critical failures

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
@dsyme dsyme merged commit 8fa9503 into main Nov 15, 2025
10 checks passed
@dsyme dsyme deleted the wv branch November 15, 2025 02:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants