Improve runtime_setup.go error messages with context and examples #4097
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Error messages in
pkg/workflow/runtime_setup.gowere too generic, lacking context about what custom steps are and why deduplication happens.Changes
Enhanced error messages (2 locations):
Parse custom steps failure (L627): Now explains that custom steps are workflow steps from frontmatter, requires valid GitHub Actions syntax, and shows example:
Marshal deduplicated steps failure (L790): Now explains deduplication removes duplicate runtime setup actions (like
actions/setup-node) to avoid conflicts when automatic detection adds them:Added test coverage:
TestRuntimeSetupErrorMessagesvalidates parse error contains explanatory contextTestDeduplicateErrorMessageFormatvalidates marshal error formatBoth errors follow the pattern: what's wrong + what's expected + example + wrapped error.
Fixes #4085
Original prompt
✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.