[docs] Consolidate string sanitization specification into developer instructions #4246
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ctions Added comprehensive section on string sanitization vs normalization patterns to the Code Organization section of developer.instructions.md. Changes: - Added "String Sanitization vs Normalization" section with 84 lines - Included Mermaid decision tree diagram for string processing choices - Documented sanitize functions (SanitizeName, SanitizeWorkflowName, SanitizeIdentifier) - Documented normalize functions (normalizeWorkflowName, normalizeSafeOutputIdentifier) - Added best practices and anti-patterns sections - Provided clear guidance on when to use each pattern This consolidates content from specs/string-sanitization-normalization.md (308 lines) into the main developer documentation. Documentation now includes 13 Mermaid diagrams (up from 12) and maintains zero marketing language across all 1,503 lines. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>
github-actions
bot
added
automation
documentation
pelikhan
approved these changes
Nov 18, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Developer Documentation Consolidation
This PR consolidates the new
specs/string-sanitization-normalization.mdspecification into the unified.github/instructions/developer.instructions.mdfile.Changes Made
string-sanitization-normalization.md)Files Modified
.github/instructions/developer.instructions.md(+84 lines, now 1503 lines total)Content Added
New Section: String Sanitization vs Normalization
Validation
✅ All markdown validated
✅ 13 Mermaid diagrams render correctly (up from 12)
✅ Consistent technical tone maintained
✅ Proper frontmatter present
✅ Zero marketing language
✅ All code blocks properly tagged
Review Notes
Please review:
Statistics