Add MCP integration tests with JSON validation for all server tools

[Copilot]

Missing integration tests for MCP server tools left JSON output format unvalidated. This adds comprehensive test coverage ensuring each tool returns valid, parseable JSON.

Changes

New test file: pkg/cli/mcp_server_json_integration_test.go

• Helper functions:

  • isValidJSON() - JSON structure validation
  • extractJSONFromOutput() - Strips console formatting (Unicode chars) from output
  • setupMCPServerTest() - Common test harness with --cmd flag to avoid gh extension requirement

• Integration tests:

  • Individual tests for status, compile, audit, logs tools validating JSON structure and expected fields
  • jq filter functionality test
  • Comprehensive test covering all 7 MCP server tools with appropriate validation per tool type

Key handling:

• Console-formatted output (e.g., ✓ .github/workflows/test.md\n[{...}]) extracted correctly
• Error cases (missing credentials, invalid run IDs) handled gracefully without false failures
• JSON field validation ensures output contracts are maintained

Example

// Extract JSON from console-formatted output
jsonOutput := extractJSONFromOutput(textContent.Text)
if !isValidJSON(jsonOutput) {
    t.Errorf("Tool did not return valid JSON")
}

var statusData []map[string]any
json.Unmarshal([]byte(jsonOutput), &statusData)

// Validate expected fields
expectedFields := []string{"workflow", "engine_id", "compiled", "status"}
for _, field := range expectedFields {
    if _, ok := statusData[0][field]; !ok {
        t.Errorf("Expected field '%s' not found", field)
    }
}

Original prompt

Add MCP integration tests for the mcp-server commands. Make sure each tool returns valid JSON.

---

✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.

[Copilot]

Pull Request Overview

This PR adds comprehensive integration tests for MCP server tools to validate JSON output format. The new test file ensures each MCP server tool returns valid, parseable JSON with expected field structures.

Key Changes:

• Adds mcp_server_json_integration_test.go with JSON validation tests for all 7 MCP server tools
• Implements helper functions for JSON extraction and validation from console-formatted output
• Includes graceful error handling for tools that may fail in test environments without credentials

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

[Copilot]

Use strings.HasPrefix(textContent.Text, \"Error:\") instead of manual bounds checking and substring comparison. This is the idiomatic Go pattern used consistently throughout the codebase (seen in 100+ locations) and is more readable and safer.

[Copilot]

Use strings.HasPrefix(textContent.Text, \"Error:\") instead of manual bounds checking and substring comparison. This is the idiomatic Go pattern used consistently throughout the codebase (seen in 100+ locations) and is more readable and safer.

[Copilot]

Use strings.HasPrefix(textContent.Text, \"Error:\") instead of manual bounds checking and substring comparison. This is the idiomatic Go pattern used consistently throughout the codebase (seen in 100+ locations) and is more readable and safer.

[Copilot]

Missing strings package import needed for the suggested strings.HasPrefix() usage to replace manual substring checks.