Add noop message parsing to logs and audit commands

[Copilot]

Noop Stats Implementation - Complete ✅

Summary

Successfully implemented noop message parsing for the logs and audit commands. The implementation follows the same pattern as the existing missing-tool feature.

Recent Updates

✅ Fixed missing JobDetails fields (commit: addressing code review feedback)

• Added JobDetails to ProcessedRun initialization from DownloadResult
• Added JobDetails to DownloadResult initialization from cached summary
• Ensures job details are properly propagated through data structures

Implementation Complete

• Add NoopReport struct similar to MissingToolReport in pkg/cli/logs.go
• Add NoopCount field to WorkflowRun struct
• Add Noops field to RunSummary, ProcessedRun, DownloadResult structs
• Create extractNoopsFromRun function in pkg/cli/logs_metrics.go
• Update logs command to call extractNoopsFromRun and populate data
• Add "Noops" column to overview table headers and rows
• Update total row calculation to include noops
• Add tests for noop extraction (logs_noop_test.go)
• Update audit command to include noop messages in report
• Add noops to audit report JSON output (AuditData struct)
• Fix missing JobDetails field propagation (code review feedback)
• All tests passing ✅
• Code formatted and linted ✅

Testing Status

✅ All tests pass

• Unit tests: make test-unit ✅
• Noop extraction tests: TestExtractNoopsFromRun ✅
• Missing tool tests: TestExtractMissingToolsFromRun ✅ (compatibility check)
• Logs/Audit tests: All passing ✅
• Build succeeds: make build ✅
• Lint passes: make lint ✅
• Format validated: make fmt ✅

Changes Made

Files Modified:

• pkg/cli/logs.go - Added NoopReport struct, NoopCount field, Noops column, fixed JobDetails propagation
• pkg/cli/logs_metrics.go - Added extractNoopsFromRun function
• pkg/cli/audit.go - Added noop extraction and reporting
• pkg/cli/audit_report.go - Added noops to AuditData struct

Files Created:

• pkg/cli/logs_noop_test.go - Comprehensive tests for noop extraction

How It Works

1. The extractNoopsFromRun function reads the agent_output.json artifact file
2. It parses items with type === "noop" from the structured JSON
3. Each noop message is stored with its timestamp and workflow metadata
4. The logs command displays noop count in the overview table
5. The audit command includes noop messages in the report
6. JSON output from both commands includes complete noop data

Example Output

Logs Overview Table:

Run ID | Workflow | Status | Duration | Tokens | Cost ($) | Turns | Errors | Warnings | Missing | Noops | Created    | Logs Path
-------|----------|--------|----------|--------|----------|-------|--------|----------|---------|-------|------------|----------
123456 | test     | success| 2m30s    | 1.5k   | 0.003    | 3     | 0      | 0        | 0       | 2     | 2024-01-15 | ./logs/...

Audit Report (Markdown):

## No-Op Messages

### Message 1

This workflow is running in read-only mode. No changes will be made.

**Timestamp**: 2024-01-15T12:00:00Z

### Message 2

Analysis complete. See report above.

**Timestamp**: 2024-01-15T12:05:00Z

JSON Output:

{
  "noops": [
    {
      "message": "This workflow is running in read-only mode. No changes will be made.",
      "timestamp": "2024-01-15T12:00:00Z",
      "workflow_name": "test-workflow",
      "run_id": 123456
    },
    {
      "message": "Analysis complete. See report above.",
      "timestamp": "2024-01-15T12:05:00Z",
      "workflow_name": "test-workflow",
      "run_id": 123456
    }
  ]
}

Implementation Notes

• Follows the exact same pattern as extractMissingToolsFromRun
• Supports both file and directory forms of agent_output.json
• Handles malformed JSON gracefully
• Includes verbose mode with message previews
• Properly tracks workflow metadata (workflow name, run ID)
• Compatible with existing caching system (RunSummary)
• Job details now properly propagated through all data structures

Original prompt

Update "logs" command (and the code that downloads the workflows) to parse the "noop" message and add a column with noop stats. The JSON result of logs/audit should contain parsed noop messages, similar to the missing-tools output type messages.

---

💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.

[Copilot]

Pull Request Overview

This PR adds noop message parsing to the logs and audit commands. Noop messages are transparency indicators logged when safe-outputs are configured but produce no GitHub API actions (e.g., running in read-only or staged mode).

Key changes:

• Adds NoopReport struct and NoopCount field to track noop messages across workflow runs
• Implements extractNoopsFromRun() function following the same pattern as extractMissingToolsFromRun()
• Enhances logs overview table with a "Noops" column showing per-run and total counts
• Adds "No-Op Messages" section to audit reports displaying full message text and timestamps

Reviewed Changes

Copilot reviewed 5 out of 5 changed files in this pull request and generated 2 comments.

Show a summary per file

File	Description
pkg/cli/logs_noop_test.go	Comprehensive unit tests for noop extraction including edge cases (malformed JSON, multiple noops, empty output)
pkg/cli/logs_metrics.go	New extractNoopsFromRun() function that parses noop entries from agent_output.json artifact files
pkg/cli/logs.go	Adds NoopReport struct, NoopCount field to WorkflowRun, integrates noop data into ProcessedRun, RunSummary, and DownloadResult, and updates logs overview table with "Noops" column
pkg/cli/audit_report.go	Adds Noops field to AuditData struct and populates it from processed run data
pkg/cli/audit.go	Extracts noops during audit workflow run processing and includes them in ProcessedRun and RunSummary

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

[Copilot]

The ProcessedRun struct is missing the JobDetails field in its initialization. The JobDetails field exists in the struct (line 71) and is populated in result.JobDetails from cached summaries (line 900), but when constructing a ProcessedRun from a fresh download result, the field is not being assigned.

This should be:

processedRun := ProcessedRun{
	Run:              run,
	AccessAnalysis:   result.AccessAnalysis,
	FirewallAnalysis: result.FirewallAnalysis,
	MissingTools:     result.MissingTools,
	Noops:            result.Noops,
	MCPFailures:      result.MCPFailures,
	JobDetails:       result.JobDetails,
}

Note: This is a pre-existing bug not introduced by this PR, but should be fixed for completeness.

Suggested change

	MCPFailures: result.MCPFailures,
	MCPFailures: result.MCPFailures,
	JobDetails: result.JobDetails,

[Copilot]

Fixed in commit 3db46d7. Added JobDetails field to ProcessedRun initialization.

[Copilot]

The JobDetails field is missing from the DownloadResult initialization when loading from cached summary. The RunSummary struct contains JobDetails (see line 140), but it's not being transferred to the result here.

This should include:

result := DownloadResult{
	Run:              summary.Run,
	Metrics:          summary.Metrics,
	AccessAnalysis:   summary.AccessAnalysis,
	FirewallAnalysis: summary.FirewallAnalysis,
	MissingTools:     summary.MissingTools,
	Noops:            summary.Noops,
	MCPFailures:      summary.MCPFailures,
	JobDetails:       summary.JobDetails,
	LogsPath:         runOutputDir,
}

Note: This is a pre-existing bug not introduced by this PR, but should be fixed for completeness.

Suggested change

	MCPFailures: summary.MCPFailures,
	MCPFailures: summary.MCPFailures,
	JobDetails: summary.JobDetails,

[Copilot]

Fixed in commit 3db46d7. Added JobDetails field to DownloadResult initialization when loading from cached summary.

[pelikhan]

@copilot lint

[Copilot]

@copilot lint

Lint completed successfully. All validations passed ✅

[pelikhan]

@copilot fix JavaScript tests

[Copilot]

@copilot fix JavaScript tests

JavaScript tests are already passing ✅

All 1067 tests in 58 test files pass successfully:

• make test-js completes without errors
• make test-unit passes all Go unit tests
• make agent-finish completes full validation successfully

No fixes needed - the test suite is healthy.

Warning

Firewall rules blocked me from connecting to one or more addresses (expand for details)

I tried to connect to the following addresses, but was blocked by firewall rules:

• https://api.github.com/user
  • Triggering command: /usr/bin/gh gh api user --jq .login (http block)

If you need me to access, download, or install something from one of these locations, you can either:

• Configure Actions setup steps to set up my environment, which run before the firewall is enabled
• Add the appropriate URLs or hosts to the custom allowlist in this repository's Copilot coding agent settings (admins only)