Skip to content

Disable threat detection on daily malicious code scan workflow #4617

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Nov 23, 2025
+27 −274
Merged

Disable threat detection on daily malicious code scan workflow #4617

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
b0be380
Initial plan
Copilot Nov 23, 2025
7e5805b
Initial investigation: Understand detection step in daily malicious c…
Copilot Nov 23, 2025
658696f
Disable detection step on daily malicious code scan workflow
Copilot Nov 23, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
268 changes: 8 additions & 260 deletions .github/workflows/daily-malicious-code-scan.lock.yml
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

1 change: 1 addition & 0 deletions .github/workflows/daily-malicious-code-scan.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,7 @@ tools:
safe-outputs:
create-code-scanning-alert:
driver: "Malicious Code Scanner"
threat-detection: false
Copy link

Copilot AI Nov 23, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The threat-detection: false configuration is incorrectly placed. According to the schema and code implementation, threat-detection should be at the same level as safe-output types (like create-code-scanning-alert), not nested under them.

Current (incorrect):

safe-outputs:
  create-code-scanning-alert:
    driver: "Malicious Code Scanner"
  threat-detection: false

Expected:

safe-outputs:
  create-code-scanning-alert:
    driver: "Malicious Code Scanner"
threat-detection: false

The threat-detection field should be a top-level frontmatter field, not nested within safe-outputs.

Suggested change
threat-detection: false
threat-detection: false

Copilot uses AI. Check for mistakes.
timeout-minutes: 15
strict: true
---
Expand Down
7 changes: 4 additions & 3 deletions .github/workflows/test-serena-custom-gomod.lock.yml
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

7 changes: 4 additions & 3 deletions .github/workflows/test-serena-go-config.lock.yml
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Loading
Loading