Skip to content

Conversation

@mnkiefer
Copy link
Contributor

@mnkiefer mnkiefer commented Nov 25, 2025

  • Switched from using Octokit to getOctokit for performing GraphQL mutations in both the main and fallback agent assignment logic.
  • Added enhanced logging for mutation operations, including token usage and mutation details, to aid debugging and auditability.

Copilot AI review requested due to automatic review settings November 25, 2025 15:27
Copilot finished reviewing on behalf of mnkiefer November 25, 2025 15:28
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR simplifies the dev workflow by replacing a complex discussion-closing workflow with a simpler agent assignment workflow. The change reduces the workflow from ~350 lines to ~10 lines in the markdown file and significantly simplifies the compiled YAML.

Key changes:

  • Replaces close_discussion safe output with assign_to_agent safe output
  • Removes extensive threat detection logic (Ollama/Llama Guard 3 scanning)
  • Removes custom Serena MCP tool configuration
  • Simplifies bash tool configuration to wildcard access
  • Updates permissions and job dependencies to match new functionality

Reviewed changes

Copilot reviewed 1 out of 2 changed files in this pull request and generated 3 comments.

File Description
.github/workflows/dev.md Simplified workflow definition: removed concurrency config, threat detection, discussion closing logic; added wildcard bash tools and assign-to-agent safe output
.github/workflows/dev.lock.yml Compiled YAML reflecting simplified workflow: removed Ollama threat scanning steps, Go/Python/uv setup, Serena MCP server, discussion closing job; added agent assignment job with GraphQL mutations and permission handling

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@mnkiefer
Copy link
Contributor Author

@copilot Analyze https://github.com/githubnext/gh-aw/actions/runs/19675058618/job/56353957110 and fix the issue in assign-to-agent.cjs. For the graphql call that uses octokit with a new token GH_AW_AGENT_TOKEN which has the required permissions. Add more logging if needed.

Copy link
Contributor

Copilot AI commented Nov 25, 2025

@mnkiefer I've opened a new pull request, #4757, to work on those changes. Once the pull request is ready, I'll request review from you.

@mnkiefer mnkiefer self-assigned this Nov 25, 2025
@mnkiefer mnkiefer merged commit 32ed00d into main Nov 25, 2025
55 checks passed
@mnkiefer mnkiefer deleted the update-dev-workflow branch November 25, 2025 17:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants