Merge missing-tools processing into conclusion job#4790
Closed
Merge missing-tools processing into conclusion job#4790
Conversation
…g_tool job Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Merge missing-tools steps into conclusion job
Merge missing-tools processing into conclusion job
Nov 26, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Consolidates the
missing_toolsafe output processing into the conclusion job rather than running it as a separate workflow job.Changes
notify_comment.go: Add missing-tool step tobuildConclusionJob, following the existing noop pattern. Includetools_reportedandtotal_countoutputs.compiler_jobs.go: RemovebuildCreateOutputMissingToolJobcall frombuildSafeOutputsJobsmissing_tool.go: Remove unusedbuildCreateOutputMissingToolJobfunctionmissing_tool_test.go: Remove job creation tests (now covered by workflow compilation tests)Result
Before:
conclusionjob depended on separatemissing_tooljobAfter:
conclusionjob runs missing-tool step inline (same as noop)No permission changes needed—conclusion job already has
contents: read.Warning
Firewall rules blocked me from connecting to one or more addresses (expand for details)
I tried to connect to the following addresses, but was blocked by firewall rules:
https://api.github.com/user/usr/bin/gh gh api user --jq .login(http block)If you need me to access, download, or install something from one of these locations, you can either:
Original prompt
💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.