Skip to content

Merge missing-tools processing into conclusion job#4790

Closed
Copilot wants to merge 2 commits intomainfrom
copilot/merge-missing-tools-logic
Closed

Merge missing-tools processing into conclusion job#4790
Copilot wants to merge 2 commits intomainfrom
copilot/merge-missing-tools-logic

Conversation

Copy link
Copy Markdown
Contributor

Copilot AI commented Nov 26, 2025

Consolidates the missing_tool safe output processing into the conclusion job rather than running it as a separate workflow job.

Changes

  • notify_comment.go: Add missing-tool step to buildConclusionJob, following the existing noop pattern. Include tools_reported and total_count outputs.
  • compiler_jobs.go: Remove buildCreateOutputMissingToolJob call from buildSafeOutputsJobs
  • missing_tool.go: Remove unused buildCreateOutputMissingToolJob function
  • missing_tool_test.go: Remove job creation tests (now covered by workflow compilation tests)

Result

Before: conclusion job depended on separate missing_tool job
After: conclusion job runs missing-tool step inline (same as noop)

# conclusion job now includes both steps
steps:
  - name: Process No-Op Messages
    id: noop
  - name: Record Missing Tool
    id: missing_tool
outputs:
  noop_message: ${{ steps.noop.outputs.noop_message }}
  tools_reported: ${{ steps.missing_tool.outputs.tools_reported }}
  total_count: ${{ steps.missing_tool.outputs.total_count }}

No permission changes needed—conclusion job already has contents: read.

Warning

Firewall rules blocked me from connecting to one or more addresses (expand for details)

I tried to connect to the following addresses, but was blocked by firewall rules:

  • https://api.github.com/user
    • Triggering command: /usr/bin/gh gh api user --jq .login (http block)

If you need me to access, download, or install something from one of these locations, you can either:

Original prompt

Merge the steps of "missing-tools" in the conclusion job, next to the noop steps. Remove missing-jobs job.
Adjust logic to generate conclusion job accordingly.
Adjust permissions for conclusion job accordingly.


💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.

…g_tool job

Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>
Copilot AI changed the title [WIP] Merge missing-tools steps into conclusion job Merge missing-tools processing into conclusion job Nov 26, 2025
Copilot AI requested a review from pelikhan November 26, 2025 00:49
@pelikhan pelikhan closed this Nov 26, 2025
@pelikhan pelikhan deleted the copilot/merge-missing-tools-logic branch December 1, 2025 03:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants