Skip to content

Fix TestGetActionPinsSorting expected count after adding action pin#5906

Merged
pelikhan merged 3 commits intomainfrom
copilot/fix-test-errors
Dec 8, 2025
Merged

Fix TestGetActionPinsSorting expected count after adding action pin#5906
pelikhan merged 3 commits intomainfrom
copilot/fix-test-errors

Conversation

Copy link
Copy Markdown
Contributor

Copilot AI commented Dec 8, 2025

Test failure in CI: TestGetActionPinsSorting expected 26 action pins but action_pins.json contains 27 entries.

Changes

  • Updated hardcoded pin count from 26 to 27 in pkg/workflow/action_pins_test.go

The test uses t.Errorf() rather than t.Fatalf(), causing it to fail silently while appearing to pass in verbose output. This was identified using go test -json output filtering.

Original prompt

Fix tests see error https://github.com/githubnext/gh-aw/actions/runs/20042721687/job/57480848957


💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.

Copilot AI and others added 2 commits December 8, 2025 21:48
Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>
The test was expecting 26 action pins, but the action_pins.json file contains 27 pins. Updated the test to match the actual count.

Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>
Copilot AI changed the title [WIP] Fix tests after identifying errors Fix TestGetActionPinsSorting expected count after adding action pin Dec 8, 2025
Copilot AI requested a review from pelikhan December 8, 2025 21:58
@pelikhan pelikhan marked this pull request as ready for review December 8, 2025 22:11
@pelikhan pelikhan merged commit c0e6074 into main Dec 8, 2025
5 checks passed
@pelikhan pelikhan deleted the copilot/fix-test-errors branch December 8, 2025 22:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants