Skip to content

Conversation

@adblanc
Copy link

@adblanc adblanc commented Jul 21, 2021

Hello,

First of all, thanks for this whole project, I really enjoy it.
However, I found myself wanting to indent the json content of my file but couldn't using the writeJSON from the lib.
I guess this shouldn't add any regressions, please let me know what you think about this 😄

@irealva
Copy link
Contributor

irealva commented Jul 22, 2021

Thank you! This seems useful and your code works well.

My only request is would you be able to take a pass at the README?

We would have to at the least:

  • update the inputs for writeJSON
  • ideally, keep the usage example, just add an extra one that shows the additional parameters

@adblanc
Copy link
Author

adblanc commented Jul 23, 2021

Thanks for the review, I had completely forgot the README part ! 😄

I used any to type replacer in the README to simplify as it's an overload with either (this: any, key: string, value: any) => any or (number | string)[] | null

@irealva
Copy link
Contributor

irealva commented Jul 26, 2021

Thanks!

@irealva irealva merged commit 59569f9 into githubocto:main Jul 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants