Skip to content

fix: hover group consistency #2380

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 13, 2025
Merged

fix: hover group consistency #2380

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
61 changes: 28 additions & 33 deletions src/renderer/components/notifications/NotificationRow.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -76,7 +76,7 @@ export const NotificationRow: FC<INotificationRow> = ({
return (
<div
className={cn(
'group border-b',
'group relative border-b',
'pl-2.75 pr-1 py-0.75',
'text-gitify-font border-gitify-notification-border hover:bg-gitify-notification-hover',
(isAnimated || animateExit) &&
Expand All @@ -85,12 +85,7 @@ export const NotificationRow: FC<INotificationRow> = ({
)}
id={notification.id}
>
<Stack
align="center"
className="relative"
direction="horizontal"
gap="condensed"
>
<Stack align="center" direction="horizontal" gap="condensed">
<Tooltip direction="e" text={notificationType}>
<button type="button">
<NotificationIcon
Expand Down Expand Up @@ -140,33 +135,33 @@ export const NotificationRow: FC<INotificationRow> = ({

<NotificationFooter notification={notification} />
</Stack>

{!animateExit && (
<HoverGroup bgColor="group-hover:bg-gitify-notification-hover">
<HoverButton
action={actionMarkAsDone}
enabled={isMarkAsDoneFeatureSupported(notification.account)}
icon={CheckIcon}
label="Mark as done"
testid="notification-mark-as-done"
/>

<HoverButton
action={actionMarkAsRead}
icon={ReadIcon}
label="Mark as read"
testid="notification-mark-as-read"
/>

<HoverButton
action={actionUnsubscribeFromThread}
icon={BellSlashIcon}
label="Unsubscribe from thread"
testid="notification-unsubscribe-from-thread"
/>
</HoverGroup>
)}
</Stack>

{!animateExit && (
<HoverGroup bgColor="group-hover:bg-gitify-notification-hover">
<HoverButton
action={actionMarkAsDone}
enabled={isMarkAsDoneFeatureSupported(notification.account)}
icon={CheckIcon}
label="Mark as done"
testid="notification-mark-as-done"
/>

<HoverButton
action={actionMarkAsRead}
icon={ReadIcon}
label="Mark as read"
testid="notification-mark-as-read"
/>

<HoverButton
action={actionUnsubscribeFromThread}
icon={BellSlashIcon}
label="Unsubscribe from thread"
testid="notification-unsubscribe-from-thread"
/>
</HoverGroup>
)}
</div>
);
};
Loading