Skip to content

gitlens.advanced.quickPick.closeOnFocusOut setting should be reversed #239

@ghost

Description

The option is documented as follows:

gitlens.advanced.quickPick.closeOnFocusOut 	Specifies whether or not to close the QuickPick menu when focus is lost

This, to me, implies that if it is true then the quickpick should close when it loses focus. But internally this option changes meaning to QuickPickIgnoreFocusOut:

export function getQuickPickIgnoreFocusOut() {
    return configuration.get<boolean>(configuration.name('advanced')('quickPick')('closeOnFocusOut').value);
}

I think the option should be inverted internally to make more sense and fit the documentation.

Metadata

Metadata

Assignees

Labels

No labels
No labels

Type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions