Skip to content

Adds threshold filter to the new home view #3718

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 8, 2024
Merged

Adds threshold filter to the new home view #3718

merged 1 commit into from
Nov 8, 2024
+195 −28

Conversation

nzaytsev
Copy link
Contributor

@nzaytsev nzaytsev commented Nov 7, 2024 •
edited
Loading

Description

Screen.Recording.2024-11-07.at.13.40.33.mov

Checklist

  • I have followed the guidelines in the Contributing document
  • My changes follow the coding style of this project
  • My changes build without any errors or warnings
  • My changes have been formatted and linted
  • My changes include any required corresponding changes to the documentation (including CHANGELOG.md and README.md)
  • My changes have been rebased and squashed to the minimal number (typically 1) of relevant commits
  • My changes have a descriptive commit message with a short title, including a Fixes $XXX - or Closes #XXX - prefix to auto-close the issue that your PR addresses

@nzaytsev nzaytsev linked an issue Nov 7, 2024 that may be closed by this pull request
Filtering of branches in Home view #3706
Closed
@nzaytsev nzaytsev force-pushed the features/3706-filtering-of-branches-in-home-view branch 2 times, most recently from 7beb06e to a52d3fb Compare November 7, 2024 06:32
@nzaytsev nzaytsev requested review from d13 and eamodio November 7, 2024 06:33
d13
d13 reviewed Nov 8, 2024
View reviewed changes
Copy link
Member

@d13 d13 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please be sure to separate the owner changes to another branch as we will not be shipping that this release.

@nzaytsev nzaytsev force-pushed the features/3706-filtering-of-branches-in-home-view branch 2 times, most recently from 5b082d1 to b7c74ae Compare November 8, 2024 08:58
@nzaytsev nzaytsev force-pushed the features/3706-filtering-of-branches-in-home-view branch from b7c74ae to 4f5e3cb Compare November 8, 2024 09:16
d13
d13 approved these changes Nov 8, 2024
View reviewed changes
Copy link
Member

@d13 d13 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's some refinements we can make after merge, but LGTM.

@d13 d13 merged commit 8781f91 into main Nov 8, 2024
3 checks passed
@d13 d13 linked an issue Nov 13, 2024 that may be closed by this pull request
New Home View #3620
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@d13 d13 d13 approved these changes

@eamodio eamodio Awaiting requested review from eamodio

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Filtering of branches in Home view New Home View

2 participants

@nzaytsev @d13