Commits paging works incorrectly

[D-CURT]

Hello.

I faced an issue with pagination while iterating by commits.

Gitlab4j API version: 4.15.7

I'm calling
api.getCommitsApi().getCommits(projectName, branchName, since, until, null, ITEMS_SIZE);

And a pager (Pager) hasNext() enternally returns true.

So, I'm stucking on:
while (pager.hasNext()) {
pager.next();
}

After pager initialization:
currentPage: 0, kaminariNextPage: 2, itemsPerPage: 100, currentItems: 111 (in my case), totalPages: -1, totalItems: -1.

The first page properties:
currentPage: 1, kaminariNextPage: 2, itemsPerPage: 100, currentItems: 111, totalPages: -1, totalItems: -1.

The second page properties:
currentPage: 2, kaminariNextPage: 3, itemsPerPage: 100, currentItems: 0, totalPages: -1, totalItems: -1.

The third page properties:
currentPage: 3, kaminariNextPage: 4, itemsPerPage: 100, currentItems: 0, totalPages: -1, totalItems: -1.
...

Thanks,
D-CURT.

[jabby]

Hello,
Since 13.5 the commits API no longer returns "X-Total-Pages" and "X-Total" headers. I suspect your problem comes from this. Can you confirm that your gitlab instance version is 13.5+?

[D-CURT]

Hello, jabby! Thanks for the answer! https://gitlab.com/help shows me 13.11.0-pre.

[jabby]

So it's related the removal of "X-Total-Pages" and "X-Total" headers. Thanks for your screenshot.

[LiuTing0729]

So, how to resolve this problem if my gitlab version is 13.5+. My company updated gitlab version last week, so I can't lower the version.

[jabby]

@LiuTing0729 it should be fixed in 2 latest releases of gitlab4j-api (4.17.0 and 4.18.0). See 4e9f7a6
Can you check and reopen if it does not work properly?