Skip to content

Deployments API does not match the documentation #773

@MDarmawan

Description

@MDarmawan

Hello,
I was working with your very useful library, using the Deployments API, and I noticed that some of the functions and methods appear to be out of date with the current version of the API shown in the GitLab Documentation.

The DeploymentsApi.getMergeRequests() function uses the path GET /projects/:id/repository/commits/:deployment_id/merge_requests on line 222, when it should be path GET /projects/:id/deployments/:deployment_id/merge_requests, according to the documentation.

Also, the DeploymentFilter class has the fields finishedAfter and finishedBefore instead of updatedAfter and updatedBefore, even though the comments appear to imply that it intends to be used that way.

     * Return deployments updated after the specified date. Expected in ISO 8601 format (2019-03-15T08:00:00Z).
     */
    private Date finishedAfter;

    /**
     * Return deployments updated before the specified date. Expected in ISO 8601 format (2019-03-15T08:00:00Z).
     */
    private Date finishedBefore;

This affects line 136-137, which the fields get passed onto the API.

Thank you for your time.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions